[pve-devel] [PATCH manager] fix-5251: login: set autocomplete on password and user
Maximiliano Sandoval
m.sandoval at proxmox.com
Mon Feb 19 11:24:50 CET 2024
By default they have 'autocomplete=off'. From [1]:
> In most modern browsers, setting autocomplete to "off" will not
> prevent a password manager from asking the user if they would like to
> save username and password information, or from automatically filling
> in those values in a site's login form. See the autocomplete
> attribute and login fields [2].
[1] https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
[2] https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#the_autocomplete_attribute_and_login_fields
Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
---
www/manager6/window/LoginWindow.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/window/LoginWindow.js b/www/manager6/window/LoginWindow.js
index a79f5a2a..aaeca355 100644
--- a/www/manager6/window/LoginWindow.js
+++ b/www/manager6/window/LoginWindow.js
@@ -344,6 +344,7 @@ Ext.define('PVE.window.LoginWindow', {
itemId: 'usernameField',
reference: 'usernameField',
stateId: 'login-username',
+ inputAttrTpl: 'autocomplete=username',
bind: {
visible: "{!openid}",
disabled: "{openid}",
@@ -355,6 +356,7 @@ Ext.define('PVE.window.LoginWindow', {
fieldLabel: gettext('Password'),
name: 'password',
reference: 'passwordField',
+ inputAttrTpl: 'autocomplete=current-password',
bind: {
visible: "{!openid}",
disabled: "{openid}",
--
2.39.2
More information about the pve-devel
mailing list