[pve-devel] [PATCH widget-toolkit 0/2] notification: set 'Remove' button text to 'Reset to default' for built-ins

Lukas Wagner l.wagner at proxmox.com
Fri Feb 16 11:15:04 CET 2024


ping - still applies on master. Retested it quickly, also seems to work fine.

On 1/8/24 11:43, Lukas Wagner wrote:
> ping
> 
> On 12/14/23 10:48, Lukas Wagner wrote:
>> Deleting a built-in target/matcher does not remove it, but resets it
>> to its default settings. This was not really obvious from the UI.
>> This patch changes the 'Remove' button text based on the
>> selected target/matcher. If it is a built-in, the button text is
>> changed to 'Reset to default'. Also, if the built-in is not actually
>> modified, the button is disabled.
>>
>> Lukas Wagner (2):
>>    remove button: allow to set custom confirmation message
>>    notify: change 'Remove' button to 'Reset to default' for built-ins
>>
>>   src/button/Button.js                | 10 ++++-
>>   src/panel/NotificationConfigView.js | 63 +++++++++++++++++++++++++++++
>>   2 files changed, 72 insertions(+), 1 deletion(-)
>>
> 

-- 
- Lukas




More information about the pve-devel mailing list