[pve-devel] [PATCH installer 0/5] proxinstall, tui: improve hostname/FQDN validation

Christoph Heiss c.heiss at proxmox.com
Thu Feb 15 13:39:33 CET 2024

This series improves various aspects regarding FQDN handling and
validation across both the GUI and TUI installer.

It (partially) addresses issue #5230 [0] in patch #5, by fixing the
regex through which we validate FQDNs in the GUI installer.

It also refactors the FQDN validation/parsing in the GUI installer, by
moving it into its own subroutine - making the whole thing bit easier to
reason about, as well as adding loads of test cases.

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=5230

Christoph Heiss (5):
  common: fqdn: do not allow overlong FQDNs as per Debian spec
  common: fqdn: implement case-insensitive comparison as per RFC 952
  proxinstall: avoid open-coding FQDN sanity check
  sys: net: do not allow overlong FQDNs as per RFCs and Debian spec
  fix #5230: sys: net: properly escape FQDN regex

 Proxmox/Sys/Net.pm                    | 29 +++++++++-
 proxinstall                           | 22 +++-----
 proxmox-installer-common/src/utils.rs | 79 ++++++++++++++++++++++++++-
 test/Makefile                         |  6 +-
 test/parse-fqdn.pl                    | 57 +++++++++++++++++++
 5 files changed, 172 insertions(+), 21 deletions(-)
 create mode 100755 test/parse-fqdn.pl


More information about the pve-devel mailing list