[pve-devel] [PATCH installer 1/4] low-level: initialize UI backend for 'dump-env' subcommand too

[Christoph Heiss]

On Fri, Feb 09, 2024 at 01:36:12PM +0100, Aaron Lauterer wrote:
> Is this something I should consider for the new dump-udev subcommand as well?
>
> https://lists.proxmox.com/pipermail/pve-devel/2024-January/061433.html

As it also calls deeper into the installer code, I'd say yes. Although
nothing ever calls UI code on that chain, better future-proof it now :^)

>
> On 2/9/24 11:55, Christoph Heiss wrote:
> > Some detection routines might try to log things and call some
> > Proxmox::Ui functions all the way down, so just initialize it with the
> > stdio backend to avoid errors.
> >
> > Signed-off-by: Christoph Heiss <c.heiss at proxmox.com>
> > ---
> >   proxmox-low-level-installer | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/proxmox-low-level-installer b/proxmox-low-level-installer
> > index d127a40..2848295 100755
> > --- a/proxmox-low-level-installer
> > +++ b/proxmox-low-level-installer
> > @@ -91,6 +91,7 @@ Proxmox::Log::init("/tmp/install-low-level-${cmd}.log");
> >   my $env = Proxmox::Install::ISOEnv::get();
> >   if ($cmd eq 'dump-env') {
> > +    Proxmox::UI::init_stdio({}, $env);
> >       my $out_dir = $env->{locations}->{run};
> >       make_path($out_dir);