[pve-devel] [PATCH qemu-server 2/4] QMP client: remove unnecessary question mark from comment
Fiona Ebner
f.ebner at proxmox.com
Fri Feb 9 13:14:25 CET 2024
There might've been a question back when it got first added in commit
9d689077 ("use long timeouts for snapshot monitor command"). But
nowadays, the value is well-established. Changing it would affect
quite a few operations, so that should not be done without good
reason and is likely better done for the specific operation.
Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
PVE/QMPClient.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QMPClient.pm b/PVE/QMPClient.pm
index 0a35db74..42e54f01 100644
--- a/PVE/QMPClient.pm
+++ b/PVE/QMPClient.pm
@@ -132,7 +132,7 @@ sub cmd {
$cmd->{execute} eq 'blockdev-snapshot-internal-sync' ||
$cmd->{execute} eq 'blockdev-snapshot-delete-internal-sync'
) {
- $timeout = 10*60; # 10 mins ?
+ $timeout = 10*60; # 10 mins
} else {
# NOTE: if you came here as user and want to change this, try using IO-Threads first
# which move out quite some processing of the main thread, leaving more time for QMP
--
2.39.2
More information about the pve-devel
mailing list