[pve-devel] [PATCH installer v2 0/3] expose zfs arc size setting for all products

Christoph Heiss c.heiss at proxmox.com
Wed Feb 7 15:28:11 CET 2024


As suggested by Thomas, leaves the ZFS default if the user never touches
the setting in the installer (i.e. not writing a modprobe file).
See also the discussion in v1 [0].

[0] https://lists.proxmox.com/pipermail/pve-devel/2024-February/061659.html

Testing
-------
Tested the installation of PVE and PBS, with each once letting the arc
size setting untouched and once setting it to some specific value.
Afterwards, checked that for PVE the module parameter was always written
to /etc/modprobe.d/, for PBS that it was only written in case it was
set.

Previous revisions
------------------
v1: https://lists.proxmox.com/pipermail/pve-devel/2023-November/060898.html

Changes v1 -> v2:
  * rebased on latest master
  * add placeholder functionality for arc max size in TUI
  * "emulate" placeholder functionality in GTK on best-effort basis

Christoph Heiss (3):
  tui: NumericEditView: add optional placeholder value
  tui: expose arc size setting for zfs bootdisks for all products
  proxinstall: expose arc size setting for zfs bootdisks for all
    products

 Proxmox/Install/RunEnv.pm                   |  3 +-
 proxinstall                                 | 37 +++++++----
 proxmox-installer-common/src/options.rs     |  3 +-
 proxmox-tui-installer/src/views/bootdisk.rs | 48 ++++++++------
 proxmox-tui-installer/src/views/mod.rs      | 69 +++++++++++++++++++--
 5 files changed, 124 insertions(+), 36 deletions(-)

--
2.42.0





More information about the pve-devel mailing list