[pve-devel] [PATCH installer 0/2] expose zfs arc size setting for all products

[Christoph Heiss]

On Tue, Feb 06, 2024 at 01:49:36PM +0100, Thomas Lamprecht wrote:
> Am 30/11/2023 um 11:01 schrieb Christoph Heiss:
> > As suggested by Thomas, sets the default to 50% for all non-PVE
> > products.
> >
> > Quickly smoke-tested this, to see if all installer show the correct
> > value in the GUI/TUI.
>
> What I'm wondering if we should skip actively setting this as module
> parameter if the user did not changed the value at all?

Sounds like a pretty reasonable "default" actually, just keeping the ZFS
defaults. So I'd be happy to implement that.

>
> That way it would stay dynamic, e.g., if one increased the memory of
> a PBS or PMG instance, but one could also interpret that as bad thing,
> especially if the MiB number was shown.

Should this behaviour only apply to the PBS/PMG installer then? Or to
PVE as well?

> For GTK we could just go for a placeholder text showing the number,
> but there isn't really such a UX-mechanic available for the TUI one
> AFAICT.

Yeah, we'd need to implement placeholders for the TUI ourselves.
Shouldn't be too hard tho, I got a rough idea mind how it be fitted in
there.

>
> Anyhow, I can be OK with always hard-coding, just wanted to know
> your (or others) thoughts on this.