[pve-devel] [PATCH common 1/2] REST environment: warn helpers: use warn instead of printing to stderr

Fiona Ebner f.ebner at proxmox.com
Mon Feb 5 14:08:11 CET 2024


Am 05.02.24 um 13:38 schrieb Thomas Lamprecht:
> Am 05/02/2024 um 13:28 schrieb Fiona Ebner:
>> Like this, __WARN__ handlers will still be called. In particular,
>> daemons like pvestatd will set a __WARN__ handler and also log
>> warnings to syslog. The intention behind introducing log_warn() was to
>> make warnings more visible, not less, so fix the semantics to make
>> sure switching from warn to log_warn() does not have this unintended
>> side-effect.
> 
> did you saw my reply w.r.t. this [0]?
> 
> https://lists.proxmox.com/pipermail/pve-devel/2024-February/061610.html

Yes, but I wanted to make log_warn and warn behave more consistently,
since I wasn't aware that they should be different. I can send a v2 with
using syslog() in log_warn() instead.




More information about the pve-devel mailing list