[pve-devel] [PATCH v1 pve-common 2/4] add tests for PVE::Path

[Thomas Lamprecht]

Am 19.12.24 um 19:31 schrieb Max Carrara:
> This commit adds a plethora of parameterized tests for all functions
> of PVE::Path (except aliases). This surmounts to 1050 tests being run
> in total. Some of these tests might perhaps be redundant, but the goal
> here was to be better safe than sorry and really make sure that
> nothing slips through.

IMO that's a little bit contradictory, as redundant tests, or not knowing
how much redundancy there is making me a bit question if this is really
worth it. I'd rather see much fewer tests but with a clear plan/idea for
what they are for; as of is this is not really reviewable and without
knowing how they got created and how much it was made sure that we do not
test ten times the same thing.

I do not want to say you do, but would like some more reasoning here than
"trust me bro" and if we can have 100, or even less, tests with the same
coverage it would be a big improvement, as that makes them much more
maintainable.