[pve-devel] [PATCH qemu-server] vmstatus: document more return types

[Dominik Csapak]

On 12/18/24 3:44 PM, Daniel Kral wrote:
> On 12/17/24 10:32, Dominik Csapak wrote:
>> namely 'cpu' and 'mem'
>>
>> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
>> ---
>>   PVE/QemuServer.pm | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
>> index b3d5f8f2..98bc07c2 100644
>> --- a/PVE/QemuServer.pm
>> +++ b/PVE/QemuServer.pm
>> @@ -2793,6 +2793,12 @@ our $vmstatus_return_properties = {
>>       type => 'string',
>>       enum => ['stopped', 'running'],
>>       },
>> +    mem => {
>> +    description => "Current memroy usage in bytes.",
> 
> just noticed that there's a small typo in the description
> 

true, did not notice that

> Is there a reason that the description is slightly different from the one in 
> pve-container?
> 

not really, i was probably not careful enough when writing both ;)

since this was already applied, you could send a followup to fix both issues
(if you want, otherwise I'll see when i can find the time for this)

>> +    type => 'integer',
>> +    optional => 1,
>> +    renderer => 'bytes',
>> +    },
>> [ ... ]
>