[pve-devel] [PATCH v2 storage 09/10] common: introduce common module

[Fiona Ebner]

Am 18.12.24 um 10:36 schrieb Max Carrara:
> On Tue Dec 17, 2024 at 4:48 PM CET, Fiona Ebner wrote:
>> From: Max Carrara <m.carrara at proxmox.com>
>>
>> This module's purpose is to provide shared functions, constants, etc.
>> for storage plugins and storage-related operations.
>>
>> It also contains the `get_deprecation_warning` subroutine that makes
>> it easier to warn developers and/or plugin authors that a subroutine
>> will be removed in the future.
> 
> Thanks for including this patch already! Was really happy to see this :)
> 
> Since I've never included a commit from somebody else's series / RFC in
> another series, is the commit message usually left as it is? You did
> mention below that you start out with a different function for your use
> case, but wouldn't it make sense to adapt the commit message overall
> accordingly? In this case, just the paragraph above my reply here.
> 

Yes, the commit message should be adapted here. Thank you for pointing
this out!