[pve-devel] [PATCH installer 1/3] proxinstall: move device changed callback after loop

Maximiliano Sandoval m.sandoval at proxmox.com
Tue Dec 17 16:23:14 CET 2024


Otherwise the callback will run once for each NIC.

Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
---
 proxinstall | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxinstall b/proxinstall
index 8168529..1d22e22 100755
--- a/proxinstall
+++ b/proxinstall
@@ -407,9 +407,9 @@ sub create_ipconf_view {
 	    &$device_change_handler($device_cb);
 	    $ipconf_first_view = 0;
 	}
-	$device_cb->signal_connect('changed' => $device_change_handler);
 	$i++;
     }
+    $device_cb->signal_connect('changed' => $device_change_handler);
 
     if (my $nic = Proxmox::Install::Config::get_mngmt_nic()) {
 	$device_cb->set_active($device_active_reverse_map->{$nic} // 0);
-- 
2.39.5





More information about the pve-devel mailing list