[pve-devel] [PATCH cluster/docs/manager/widget-toolkit v3 0/4] fix #5463: add optional Consent Banner on login
Gabriel Goller
g.goller at proxmox.com
Tue Dec 10 17:11:54 CET 2024
The consent text is stored in the datacenter.cfg file and is encoded
using base64. This allows us to support multi-line strings and special
characters. To easily edit the text the existing edit-field
ProxmoxTextAreaField is used. It supports editing and saving
multi-line text and converting it to its base64 representation.
This is the port from the initial PBS implementation and should work
in the same way.
v3:
- limit max characters in backend as well
- set a limit of 63*1024 in the frontend (a bit less than max request body size)
- set a limit of 128kB in the backend
v2, thanks @Thomas:
- limit max characters for consent-text (24000)
- wrap datacenter config read in eval
- fix js indentation
- remove Ext.htmlEncode (this is done by Markdown.parse)
manager:
Gabriel Goller (1):
show optional consent-banner before login
PVE/Service/pveproxy.pm | 13 ++++++++++---
www/index.html.tpl | 3 ++-
www/manager6/dc/OptionView.js | 8 ++++++++
www/manager6/window/LoginWindow.js | 12 +++++++++++-
4 files changed, 31 insertions(+), 5 deletions(-)
cluster:
Gabriel Goller (1):
add consent-text parameter to datacenter config file
src/PVE/DataCenterConfig.pm | 6 ++++++
1 file changed, 6 insertions(+)
docs:
Gabriel Goller (1):
add consent-banner description
pve-gui.adoc | 9 +++++++++
1 file changed, 9 insertions(+)
widget-toolkit:
Gabriel Goller (1):
form: set enforceMaxLength on textareafield
src/form/TextAreaField.js | 1 +
1 file changed, 1 insertion(+)
Summary over all repositories:
7 files changed, 47 insertions(+), 5 deletions(-)
--
Generated by git-murpp 0.7.1
More information about the pve-devel
mailing list