[pve-devel] SPAM: [PATCH pve-network 2/2] dhcp: generate dhcp-range for dnsmasq even when no dhcp_ranges exist

[Lou.Lecrivain at wdz.de]

Re,

Seems like I did not test this enough, whoops.

> Maybe it would make sense to move the whole code of configure_range to
> configure_subnet in the Dnsmasq plugin, since the whole subnet gets
> configured anyway and make configure_range a noop?
Yes, do agree on this one. I think it'd be cleaner in terms of code.

I'll take this into account for next version. Thanks.

BR
________________________________________
De : Stefan Hanreich <s.hanreich at proxmox.com>
Envoyé : jeudi 5 décembre 2024 17:20
À : Proxmox VE development discussion <pve-devel at lists.proxmox.com>
Cc : Lecrivain, Lou (WDZ) <Lou.Lecrivain at wdz.de>
Objet : [!!ACHTUNG extern!!] - Re: [pve-devel] SPAM: [PATCH pve-network 2/2] dhcp: generate dhcp-range for dnsmasq even when no dhcp_ranges exist
 
Seems like this still is a remnant from when we used to configure the
ranges explicitly dhcp-range. But adding two DHCP ranges just generates
two identical lines in the dnsmasq config:

> dhcp-range=set:public-172.20.44.0-24,172.20.44.0,static,255.255.255.0,infinite
> dhcp-range=set:public-172.20.44.0-24,172.20.44.0,static,255.255.255.0,infinite

Maybe it would make sense to move the whole code of configure_range to
configure_subnet in the Dnsmasq plugin, since the whole subnet gets
configured anyway and make configure_range a noop?