[pve-devel] [PATCH proxmox 1/2] notify: smtp: add missing 'tracing' namespace prefix

[Gabriel Goller]

On 06.12.2024 11:10, Lukas Wagner wrote:
>This section of code is only compiled when the 'mail-forwarder' feature
>is enabled, which might have been the reason why this was missed when the
>other places where log messages are produced were migrated to 'tracing'.

Oh that's why I didn't get an error when compiling.
Anyway consider:

Reviewed-by: Gabriel Goller <g.goller at proxmox.com>

>
>Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
>---
> proxmox-notify/src/endpoints/smtp.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/proxmox-notify/src/endpoints/smtp.rs b/proxmox-notify/src/endpoints/smtp.rs
>index 6bb2d2d0..86911f9b 100644
>--- a/proxmox-notify/src/endpoints/smtp.rs
>+++ b/proxmox-notify/src/endpoints/smtp.rs
>@@ -336,7 +336,7 @@ impl Endpoint for SmtpEndpoint {
>                                 let header = HeaderValue::new(name, value);
>                                 message.headers_mut().insert_raw(header);
>                             }
>-                            Err(e) => error!("could not set header: {e}"),
>+                            Err(e) => tracing::error!("could not set header: {e}"),
>                         }
>                     }
>                 }
>-- 
>2.39.5
>