[pve-devel] [PATCH v3 1/2] log: add perlmod logger and custom formatter

[Lukas Wagner]

On  2024-12-05 16:10, Gabriel Goller wrote:
> Add special logger for perlmod. This one will print everything to
> stderr (which will end up in the tasklog) and the errors to journald.
> This also includes a custom formatter so that the stderr output will
> look like: "INFO: sample message".
> 
> Reported-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
> Reported-by: Lukas Wagner <l.wagner at proxmox.com>
> Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
> ---
> 
> I didn't include Lukas's T-b as I changed quite a lot on this 
> patch.
> 

Gave v3 another quick spin, seems to work as advertised. Code also
looks good to me, though I have to say that I don't know much about
the tracing ecosystem.

Tested-by: Lukas Wagner <l.wagner at proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner at proxmox.com>

Maybe another set of eyes would be good, as I'm not sure if I'm overlooking some
issue regarding 'always logging to stderr' part in non-task context.

-- 
- Lukas