[pve-devel] [PATCH v2] log: change default output to stderr and only log errors to journald

Gabriel Goller g.goller at proxmox.com
Thu Dec 5 11:23:47 CET 2024


Change the from the pbs logger to the special perlmod logger, which logs
every line to stderr and the errors directly to journald.
Previously every perlmod output went directly to journald, now it is
also visible in the tasklog (through stderr).

Reported-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
Reported-by: Lukas Wagner <l.wagner at proxmox.com>
Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
---

v2, thanks @Lukas:
 - remove unnecessary hunk

 common/src/logger.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/src/logger.rs b/common/src/logger.rs
index 1c8940ba4588..9bae08232d03 100644
--- a/common/src/logger.rs
+++ b/common/src/logger.rs
@@ -5,7 +5,7 @@ pub fn init(env_var_name: &str, default_log_level: &str) {
     if let Err(e) = default_log_level
         .parse()
         .map_err(Error::from)
-        .and_then(|default_log_level| proxmox_log::init_logger(env_var_name, default_log_level))
+        .and_then(|default_log_level| proxmox_log::init_perlmod_logger(env_var_name, default_log_level))
     {
         eprintln!("could not set up env_logger: {e:?}");
     }
-- 
2.39.5





More information about the pve-devel mailing list