[pve-devel] [PATCH proxmox-perl-rs] log: change default output to stderr and only log errors to journald
Gabriel Goller
g.goller at proxmox.com
Thu Dec 5 11:16:36 CET 2024
Change the from the pbs logger to the special perlmod logger, which logs
every line to stderr and the errors directly to journald.
Previously every perlmod output went directly to journald, now it is
also visible in the tasklog (through stderr).
Reported-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
Reported-by: Lukas Wagner <l.wagner at proxmox.com>
Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
---
common/src/logger.rs | 2 +-
pve-rs/Cargo.toml | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/common/src/logger.rs b/common/src/logger.rs
index 1c8940ba4588..9bae08232d03 100644
--- a/common/src/logger.rs
+++ b/common/src/logger.rs
@@ -5,7 +5,7 @@ pub fn init(env_var_name: &str, default_log_level: &str) {
if let Err(e) = default_log_level
.parse()
.map_err(Error::from)
- .and_then(|default_log_level| proxmox_log::init_logger(env_var_name, default_log_level))
+ .and_then(|default_log_level| proxmox_log::init_perlmod_logger(env_var_name, default_log_level))
{
eprintln!("could not set up env_logger: {e:?}");
}
diff --git a/pve-rs/Cargo.toml b/pve-rs/Cargo.toml
index 4b6dec6ff452..2c06c8de176b 100644
--- a/pve-rs/Cargo.toml
+++ b/pve-rs/Cargo.toml
@@ -35,9 +35,9 @@ proxmox-apt = { version = "0.11.5", features = ["cache"] }
proxmox-apt-api-types = "1.0"
proxmox-config-digest = "0.1"
proxmox-http = { version = "0.9", features = ["client-sync", "client-trait"] }
-proxmox-http-error = "0.1.0"
-proxmox-log = "0.2"
-proxmox-notify = { version = "0.5", features = ["pve-context"] }
+proxmox-http-error = { version = "0.1.0", path="/home/ggoller/dev/proxmox/perlmod_logger/proxmox-http-error/" }
+proxmox-log = {version = "0.2", path="/home/ggoller/dev/proxmox/perlmod_logger/proxmox-log/" }
+proxmox-notify = { version = "0.5", features = ["pve-context"], path="/home/ggoller/dev/proxmox/perlmod_logger/proxmox-notify/" }
proxmox-openid = "0.10"
proxmox-resource-scheduling = "0.3.0"
proxmox-shared-cache = "0.1.0"
--
2.39.5
More information about the pve-devel
mailing list