[pve-devel] [PATCH proxmox] notify: remove legacy filters and groups

[Lukas Wagner]

On  2024-12-02 16:29, Thomas Lamprecht wrote:
> Am 02.12.24 um 14:32 schrieb Lukas Wagner:
>> It has been a full year now, so I'd argue it is safe to drop these
>> safety guards now. On the off chance that there are still systems out
>> there which still have these entries in their notifications.cfg,
>> a manual removal from the file will be needed after this commit.
> 
> It be safer to argue versions not time here, as users simply can not upgrade
> a system for over a year and then run into such things, if the boundary is a
> major version OTOH they cannot run into this by just upgrading, and we could
> add a safety check to the future pve8to9 upgrade checker script.

Yes, you are right about versions being the more important factor.

Since this is a just a bit of cleanup in proxmox-notify, I see no problem with postponing
this until PVE 9 and then adding it as a check to the pve8to9 script.
There really is no rush for this and this seems to be less work than adding a check
to d/postinst.

Thanks for your input!

> 
> But, it indeed seems a bit unlikely to trigger frequently in practice, so as
> middleground we could add a simple detection heuristic to d/postinst and if
> an old-style notification is detected print a big notice about how one can
> fix this manually or try to rename the config file to notifications.cfg.old
> or the like, as we basically can never have the legacy and new stuff mixed
> IIRC.

-- 
- Lukas