[pve-devel] [PATCH] webhook edit: do not split translatable strings

Maximiliano Sandoval m.sandoval at proxmox.com
Mon Dec 2 14:24:19 CET 2024


"Shannon Sterz" <s.sterz at proxmox.com> writes:

> wouldn't it be more elegant to simply define `addLabel` as
> `gettext('Add')` and then override that where needed? that would safe
> this akward ternary operator. haven't tested that though.

Not sure to be honest. Whenever in doubt I try to leave the logic as
close as possible to the original. If anyone feels somewhat strongly
about this I can make a v2.

--
Maximiliano




More information about the pve-devel mailing list