[pve-devel] [PATCH installer v2 06/17] common: setup: deserialize `secure_boot` property from runtime env

Christoph Heiss c.heiss at proxmox.com
Mon Aug 19 12:32:09 CEST 2024


On Tue, Jul 23, 2024 at 04:31:35PM GMT, Aaron Lauterer wrote:
> In my tests, with secure boot disabled, it failed to parse the
> run-env-info.json because the Perl code wrote it this way:
>
> "secure_boot":""
>
> And it currently cannot parse a string. Setting it manually to:
>
> "secure_boot":0
>
> helped. The question is, if we want the parser to be more flexible or fix
> the Perl code that dumps that info.

FWIW: Testing this, I couldn't actually reproduce this.

Re-reading the dumping code in Proxmox/Install/RunEnv.pm, I'd also
expect this. In the non-secureboot case, the hash member isn't set, so
the key should not be dumped at all. Otherwise, 1 as value gets dumped.

So I'm not sure how the perl code would even get to dumping an empty
string ..




More information about the pve-devel mailing list