[pve-devel] [PATCH storage 1/2] don't bail on whitespaces in backing devices

Dominik Csapak d.csapak at proxmox.com
Tue Apr 30 11:45:05 CEST 2024


On 4/30/24 11:13, Fiona Ebner wrote:
> Am 30.04.24 um 10:38 schrieb Wolfgang Bumiller:
>> - technically users could add a disk with a "bad" parent to a storage
>>    *manually*, but given the list_images mentioned above, I'd argue the
>>    situation isn't really getting worse, as values that *do* match `\S+`
>>    don't necessarily match the regexes used *later* on the parent
>>    *anyway*...
>>
> 
> CC Dominik
> 
> Thinking in the context of uploading OVAs (or uploading disk images), I
> guess we need a check against arbitrary backing file paths in uploaded
> qcow2/vmdk images (or do we already have that)?
> 

good point, we currently don't, but it shouldn't be hard to add that check
before importing/after uploading... i'll look into that




More information about the pve-devel mailing list