[pve-devel] partially-applied-series: [PATCH many v2 00/20] notifications: move template strings to template files; PBS preparations

[Thomas Lamprecht]

Am 19/04/2024 um 16:17 schrieb Lukas Wagner:
> proxmox:
> 
> Lukas Wagner (12):
>   notify: switch to file-based templating system
>   notify: make api methods take config struct ownership
>   notify: convert Option<Vec<T>> -> Vec<T> in config structs
>   notify: don't make tests require pve-context
>   notify: make the `mail-forwarder` feature depend on proxmox-sys
>   notify: cargo.toml: add spaces before curly braces
>   notify: give each notification a unique ID
>   notify: api: add get_targets
>   notify: derive `api` for Deleteable*Property
>   notify: derive Deserialize/Serialize for Notification struct
>   notify: pbs context: include nodename in default sendmail author
>   notify: renderer: add relative-percentage helper from PBS
> 
>  proxmox-notify/Cargo.toml                   |   7 +-
>  proxmox-notify/examples/render.rs           |  63 ------
>  proxmox-notify/src/api/gotify.rs            |  48 ++---
>  proxmox-notify/src/api/matcher.rs           |  59 +++--
>  proxmox-notify/src/api/mod.rs               | 113 ++++++++--
>  proxmox-notify/src/api/sendmail.rs          |  60 +++---
>  proxmox-notify/src/api/smtp.rs              | 122 +++++------
>  proxmox-notify/src/context/mod.rs           |  10 +-
>  proxmox-notify/src/context/pbs.rs           |  18 +-
>  proxmox-notify/src/context/pve.rs           |  15 ++
>  proxmox-notify/src/context/test.rs          |   9 +
>  proxmox-notify/src/endpoints/common/mail.rs |  20 +-
>  proxmox-notify/src/endpoints/gotify.rs      |  12 +-
>  proxmox-notify/src/endpoints/sendmail.rs    |  34 +--
>  proxmox-notify/src/endpoints/smtp.rs        |  38 ++--
>  proxmox-notify/src/lib.rs                   |  59 ++---
>  proxmox-notify/src/matcher.rs               |  71 +++---
>  proxmox-notify/src/renderer/html.rs         |  14 --
>  proxmox-notify/src/renderer/mod.rs          | 226 ++++++++------------
>  proxmox-notify/src/renderer/plaintext.rs    |  39 ----
>  20 files changed, 506 insertions(+), 531 deletions(-)
>  delete mode 100644 proxmox-notify/examples/render.rs
> 
> 

applied above, i.e., the proxmox/proxmox-notify ones. 

As talked off-list, for the PVE side I'd like to wait out the next one or two
weeks until the dust of the release settles. Until then, the libpve-rs should
stay on the proxmox-notify 0.3 release, while a hot-fix would be slightly more
work, it's still doable – so I see no real practical issue in having this
divergence between PVE and PBS (where this is all completely new anyway).