[pve-devel] applied: [PATCH installer] auto-installer: move ssh keys setup to low-level installer

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Apr 23 17:26:02 CEST 2024


Am 23/04/2024 um 16:44 schrieb Christoph Heiss:
> .. thereby, also fixing a accidental shell injection.
> 
> Since run_cmd{,s}() is nowhere else used anymore, they can be removed
> too.
> 
> Also mostly reverts commit
> 
>   5878dc4ae "auto-installer: handle auto-reboot info messages directly"
> 

would have preferred a bit more reasoning and possibly having this split
in two patches, but fine enough I guess.

> in the process too.
> 
> Reported-by: Friedrich Weber <f.weber at proxmox.com>
> Signed-off-by: Christoph Heiss <c.heiss at proxmox.com>
> ---
>  Proxmox/Install.pm                            |  7 ++
>  Proxmox/Install/Config.pm                     |  4 ++
>  .../src/bin/proxmox-auto-installer.rs         | 34 +--------
>  proxmox-auto-installer/src/utils.rs           | 70 ++-----------------
>  .../resources/parse_answer/disk_match.json    |  2 +-
>  .../parse_answer/disk_match_all.json          |  2 +-
>  .../parse_answer/disk_match_any.json          |  2 +-
>  .../tests/resources/parse_answer/minimal.json |  2 +-
>  .../resources/parse_answer/nic_matching.json  |  2 +-
>  .../resources/parse_answer/specific_nic.json  |  2 +-
>  .../tests/resources/parse_answer/zfs.json     |  2 +-
>  proxmox-installer-common/src/setup.rs         |  2 +
>  proxmox-tui-installer/src/setup.rs            |  1 +
>  13 files changed, 27 insertions(+), 105 deletions(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list