[pve-devel] applied: [PATCH proxmox-firewall] firewall: properly cleanup tables when firewall is inactive

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Apr 23 16:32:18 CEST 2024


Am 23/04/2024 um 11:21 schrieb Stefan Hanreich:
> When executing multiple nft commands they are transactional, either
> all get applied or none. When only the host or guest firewall is
> active, only one table exists and this causes the delete commands to
> fail. To fix this we need to send the delete commands separately.
> 
> It might make sense to support running multiple separate batches in
> the NftClient in the future in order to avoid having to call nft
> twice.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich at proxmox.com>
> ---
>  proxmox-firewall/src/bin/proxmox-firewall.rs |  9 +++++----
>  proxmox-firewall/src/firewall.rs             | 10 +++++-----
>  2 files changed, 10 insertions(+), 9 deletions(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list