[pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox

[Thomas Lamprecht]

Am 22/04/2024 um 15:24 schrieb Fiona Ebner:
> Am 22.04.24 um 15:16 schrieb Dominik Csapak:
>> On 4/22/24 15:11, Fiona Ebner wrote:
>>> Should we display some hint that Intel can/should also be used even if
>>> you have an AMD? Maybe even just in the text we display, like "Intel
>>> (also used for AMD)" but hope somebody can come up with something better.
>>
>> mhh.. i mean it is a virtual device, so should we also add this info
>> for e.g. e1000 devices?

Intel e1000 is a network card where no real relation to similar models from
AMD exist, nor is the network market a duopoly like the (x86_64) CPU market;
so this comparison does not really work IMO.

> Personally, I'd go in assuming the "Intel" setting is wrong with my AMD
> CPU and so might many users.
> 
>> since it's in the advanced section and it is documented in pve-docs,
>> i'd leave it out here (we can still add a notice later if users
>> are confused, but most users won't use/need it anyway)
> 
> Yes, we could also wait. But if the confusion can be avoided/reduced
> without much effort, I think it's worth doing up-front.

Yeah, definitively agreed, this is guaranteed to be a source of confusion
otherwise. I changed the display value to "Intel (AMD Compatible)".
Albeit now I'm thinking that it might have been slightly better to
lowercase "compatible", oh well..

https://git.proxmox.com/?p=pve-manager.git;a=commit;h=216398458d4be8781155f7d64835a38971258793