[pve-devel] applied: [PATCH manager] acme: ui: handle missing meta field in directory response

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Apr 22 12:39:33 CEST 2024


Am 22/04/2024 um 11:01 schrieb Folke Gleumes:
> When none of the meta fields is set by the directory, the whole
> dictionary is missing from the response, leading to an exception
> when testing for fields inside it.
> 
> Signed-off-by: Folke Gleumes <f.gleumes at proxmox.com>
> ---
>  www/manager6/node/ACME.js | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
>

applied, thanks!

fwiw and just to have it noted, as this is pre-existing and so not the fault
of your EAB patches: this component could do well with some style rework,
manual IDs, split between viewModel and custom window.down('') querys +
change/disable/.. logic and quite a few intermediate variables that are only
used once.




More information about the pve-devel mailing list