[pve-devel] partially-applied: [PATCH manager v2 1/2] ui: dc: backup: improve UX for the different 'notification-mode's
Thomas Lamprecht
t.lamprecht at proxmox.com
Sun Apr 21 13:50:25 CEST 2024
Am 15/04/2024 um 11:51 schrieb Lukas Wagner:
> - Switch order of 'mailto' and 'mailnotification' field
> - When mode is 'auto', disable 'mailtnotification' field
> - When mode is 'auto' and 'mailto' is empty, show
> hint that the notification system will be used
If one starts making lists about different things a commit does, it might
be good to evaluate if it should be split into multiple commits..
I dropped the hint part, this is IMO really not better than nothing in
its current state, as besides being quite flashy it doesn't really
explains what's going on.
Now with the advanced tab we could move the extra fields in there, add a
extended explanation potentially even providing a link to the local docs'
notification section (or wherever this is explained in detail in the
docs).
As compromise for now I'd accept that text without the pmx-hint class and
a link to the docs added in the text (could also be just a question mark
icon at the end, i.e. the help button without a text label).
More information about the pve-devel
mailing list