[pve-devel] [PATCH proxmox 09/19] notify: derive Deserialize/Serialize for Notification struct

[Fiona Ebner]

Nit: I always like a quick sentence for who needs it for such changes.

Am 09.04.24 um 15:25 schrieb Lukas Wagner:
> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
> ---
>  proxmox-notify/src/lib.rs | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/proxmox-notify/src/lib.rs b/proxmox-notify/src/lib.rs
> index 91c0b61..8d4dc63 100644
> --- a/proxmox-notify/src/lib.rs
> +++ b/proxmox-notify/src/lib.rs
> @@ -159,11 +159,13 @@ pub trait Endpoint {
>      fn disabled(&self) -> bool;
>  }
>  
> -#[derive(Debug, Clone)]
> +#[derive(Debug, Clone, Serialize, Deserialize)]
> +#[serde(rename_all = "kebab-case")]
>  pub enum Content {
>      /// Title and body will be rendered as a template
>      Template {
>          /// Name of the used template
> +        #[serde(rename = "template-name")]

So I guess this is here, because the rename_all above is not recursive?
Should we put rename_all on top of Template and ForwardedMail (if that
even works), so we are sure not to forget it for potential future fields?

>          template_name: String,
>          /// Data that can be used for template rendering.
>          data: Value,