[pve-devel] [PATCH manager 4/4] ui: enable upload/download buttons for 'import' type storages

[Dominik Csapak]

On 4/18/24 13:20, Fiona Ebner wrote:
> Am 16.04.24 um 15:19 schrieb Dominik Csapak:
>> diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js
>> index 3c5bba88..79a6e8a6 100644
>> --- a/www/manager6/window/UploadToStorage.js
>> +++ b/www/manager6/window/UploadToStorage.js
>> @@ -11,6 +11,7 @@ Ext.define('PVE.window.UploadToStorage', {
>>       acceptedExtensions: {
>>   	iso: ['.img', '.iso'],
>>   	vztmpl: ['.tar.gz', '.tar.xz', '.tar.zst'],
>> +	'import': ['ova'],
> 
> Nit: not ordered alphabetically, single quotes not required for key

generally you're right about the quotes, but in this case required
as 'import' is a reserved name and eslint will complain about
unquoted reserved words in that context ;)

> 
> Missing dot before ova
> 
>>       },
>>   
>>       cbindData: function(initialConfig) {
> 
> 
> Apart from that, all pve-manager patches:
> 
> Reviewed-by: Fiona Ebner <f.ebner at proxmox.com>