[pve-devel] [PATCH storage] plugin: move definition for 'port' option to base plugin

[Fiona Ebner]

Am 17.04.24 um 16:55 schrieb Thomas Lamprecht:
> Am 15/04/2024 um 14:48 schrieb Fiona Ebner:
>> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
>> index 22a9729..5f49830 100644
>> --- a/src/PVE/Storage/Plugin.pm
>> +++ b/src/PVE/Storage/Plugin.pm
>> @@ -205,6 +205,14 @@ my $defaultData = {
>>  	    format => 'pve-storage-options',
>>  	    optional => 1,
>>  	},
>> +	port => {
>> +	    description => "For PBS/ESXi, use this port to connect to the storage instead of the"
> 
> I'd probably avoid hard-coding "PBS/ESXi" here, it would work as good if that
> part would be omitted:
> 
> "Use this port to connect to the storage instead of the default one."
> 
> In the long run we should switch to a per-plugin schema, like the (IIRC)
> mappings have, as then we could correctly define defaults and descriptions
> without having to be overly general to fit a common denominator.
> 

I was thinking, users might stumble upon this e.g. with "man pvesm", and
then try it for storages like NFS and wonder why it doesn't work. With
the "options" option we also explicitly mention NFS/CIFS. I'll send a v2
without mentioning PBS/ESXi if you still want me to after reading my
rationale (should remember to also mention such seemingly little things
in the commit message).