[pve-devel] applied: [PATCH v2 access-control] fix #5335: stable sorting in user.cfg

[Fabian Grünbichler]

with T-B added, thanks!

PVE::AccessControl would benefit from a code style cleanup in general,
it's one of the more older modules with lots of "old style" code around..

On April 16, 2024 12:53 pm, Folke Gleumes wrote:
> Hi,
> 
> thanks for your contribution!
> 
> Looks fine to me. The saving function itself already sorts everything
> else, so this should be the last point where it can be indeterministic.
> 
> While at it, could you update the foreach to a for? Not all code
> already agrees with our style guide, but we try to update it whenever
> we are touching it [0].
> 
> If you haven't done so already, you need to agree to the Harmony CLI
> before we can accept your contribution [1].
> 
> Gave it a spin and ran some configurations, so you can consider this:
> Tested-by: Folke Gleumes <f.gleumes at proxmox.com>
> 
> [0] https://pve.proxmox.com/wiki/Perl_Style_Guide
> [1]
> https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright
> 
> On Tue, 2024-04-16 at 09:27 +0200, Daniel Krambrock via pve-devel
> wrote:
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel at lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
>