[pve-devel] applied: [PATCH v3 pve-network 00/12] SDN: Testing VNets as a blackbox and fixing found bugs

[Thomas Lamprecht]

Am 05/04/2024 um 15:17 schrieb Stefan Lendl:
> This add several tests for SDN VNets.
> State setup as well as testing results is done only via the API to test on the
> API boundaries and not against the internal state. Internal state and config
> files are mocked to avoid requiring access to system files or pmxcfs.
> 
> The first 4 commits fix functionality, identified as bugs thanks to the tests.
> 
> The next 7 commits extract various functions to allow mocking them in the
> tests. The tests are then added as the test_vnets_blackbox test.
> The last commit removes the old vnets tests which are not working anyway.
> 
> Tests validate the events of a nic joining a VNet or a nic staring on a VNet.
> These events are tested with with different subnet configurations.
> Mainly for IPv4 and/or IPv6 configurations and odd combinations.
> Further descriptions in the commit.
> 
> Differences v2 -> v3:
> * Fix functionalitiy in VNet and Subnet so all tests pass
>   Thanks @s.hanreich for lots of testing
> * Update and add more tests
> * Make it build in sbuild
> 
> Differences v1 -> v2:
> * Add tests that expect a failure when no IP can be allocated
> * Removed commented out debug stuff
> 
> 
> Stefan Hanreich (2):
>   sdn: dhcp: only consider subnets that have dhcp-range configured
>   sdn: dhcp: rollback allocated ips on failure
> 
> Stefan Lendl (10):
>   sdn: dhcp: get next free ip for a specific IP version
>   sdn: dhcp: request both IPv4 and IPv6 addresses on VM start
>   sdn: zones: extract function that reads datacenter config
>   dns: dnsmasq: extract function to systemctl command.
>   sdn: dnsmasq: extract function that generates the ethers file path
>   sdn: dnsmasq: extract function that updates dnsmasq lease via dbus
>   sdn: api: extract function that creates the sdn directory.
>   debian: blackbox tests depend on libpve-access-control at build
>   tests: test VNets functionality as a blackbox
>   tests: remove old Vnets tests
> 
>  debian/control                            |   1 +
>  src/PVE/API2/Network/SDN/Zones.pm         |   6 +-
>  src/PVE/Network/SDN/Dhcp/Dnsmasq.pm       |  47 +-
>  src/PVE/Network/SDN/Subnets.pm            |   2 +-
>  src/PVE/Network/SDN/Vnets.pm              |  29 +-
>  src/PVE/Network/SDN/Zones/EvpnPlugin.pm   |   3 +-
>  src/PVE/Network/SDN/Zones/Plugin.pm       |   5 +
>  src/PVE/Network/SDN/Zones/SimplePlugin.pm |   2 +-
>  src/test/Makefile                         |   5 +-
>  src/test/run_test_vnets.pl                | 343 ---------
>  src/test/run_test_vnets_blackbox.pl       | 894 ++++++++++++++++++++++
>  11 files changed, 962 insertions(+), 375 deletions(-)
>  delete mode 100755 src/test/run_test_vnets.pl
>  create mode 100755 src/test/run_test_vnets_blackbox.pl
> 


applied series, thanks!