[pve-devel] [PATCH pve-ceph] fix compatibility with CPUs not supporting SSE 4.1 instructions

[Thomas Lamprecht]

Am 18/09/2023 um 18:02 schrieb Dietmar Maurer:
>> One of our users ran into issues with running Ceph on older CPU
>> architectures [1]. This is apparently due to a bug in gcc-12 that
>> leads to SSE 4.1 instructions always being executed rather than
>> dynamically dispatching functions using those instructions.
> 
> Cant we fix the GCC bug instead?
> 

And recompile *all* packages to ensure binary compat?

Note that this would need much more investigation to actually see if
it is indeed a bug, or if gf-complete does something weird with their
lots of C and inline assembly that is actually fine (i.e., one of the
millions of undefined behavior of C where the compiler can do whatever),
as we really only got reports for this specific library, if it'd be a
more general bug it would probably affect many more programs.

So, compiling with O1 is by far the quickest and more targeted solution
for us, and  as gf-compat dynamically dispatches vectorized instructions
depending on available support anyway, it has no real performance impact,
at least none we could measure.

FWIW, the Debian openstack team choose the same solution [0] after
coming to no real conclusion on their research into this matter [1].

[0]: https://salsa.debian.org/openstack-team/third-party/gf-complete/-/commit/03e0314af5e814a7ef74dcf4f9416d60c6322e51
[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012935


So, while yes, we could spend (potentially a lot of) time on
investigating this, with the current information we have, I'd rather
avoid that for now, especially as I have a gut-feeling that this
bug is just a result of gf-complete oddness and C being C, and
I don't want to mess with that more than really needed.