[pve-devel] [PATCH pve-zsync] parse disks: improve error messages

[Stefan Sterz]

On Tue Sep 12, 2023 at 11:31 AM CEST, Fiona Ebner wrote:
> The one with the backup flag was reported in the community forum:
> https://forum.proxmox.com/threads/77254/
>
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
>  pve-zsync | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/pve-zsync b/pve-zsync
> index 98190b2..0e48865 100755
> --- a/pve-zsync
> +++ b/pve-zsync
> @@ -949,11 +949,12 @@ sub parse_disks {
>  	    $num++;
>
>  	} else {
> -	    die "ERROR: in path\n";
> +	    die "unexpected path '$path'\n";
>  	}
>      }
>
> -    die "Vm include no disk on zfs.\n" if !$disks->{0};
> +    die "guest does not include any ZFS volumes (or all excluded by the backup flag).\n"

small nit: "guest" should be capitalized if this is the beginning of a
sentence. and imo "all are excluded" sounds more proper.

> +	if !$disks->{0};
>      return $disks;
>  }
>
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel