[pve-devel] [PATCH manager] ui: replication: backup: use renderEnabledIcon to render the enabled column

Lukas Wagner l.wagner at proxmox.com
Fri Sep 1 08:55:06 CEST 2023


Ping

On 7/18/23 11:53, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
> ---
>   www/manager6/dc/Backup.js        | 3 +--
>   www/manager6/grid/Replication.js | 3 +--
>   2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
> index 03a02651..e662dd36 100644
> --- a/www/manager6/dc/Backup.js
> +++ b/www/manager6/dc/Backup.js
> @@ -722,8 +722,7 @@ Ext.define('PVE.dc.BackupView', {
>   		    width: 80,
>   		    dataIndex: 'enabled',
>   		    align: 'center',
> -		    // TODO: switch to Proxmox.Utils.renderEnabledIcon once available
> -		    renderer: enabled => `<i class="fa fa-${enabled ? 'check' : 'minus'}"></i>`,
> +		    renderer: Proxmox.Utils.renderEnabledIcon,
>   		    sortable: true,
>   		},
>   		{
> diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js
> index 30cd6718..1e4e00fc 100644
> --- a/www/manager6/grid/Replication.js
> +++ b/www/manager6/grid/Replication.js
> @@ -283,8 +283,7 @@ Ext.define('PVE.grid.ReplicaView', {
>   		width: 80,
>   		dataIndex: 'enabled',
>   		align: 'center',
> -		// TODO: switch to Proxmox.Utils.renderEnabledIcon once available
> -		renderer: enabled => `<i class="fa fa-${enabled ? 'check' : 'minus'}"></i>`,
> +		renderer: Proxmox.Utils.renderEnabledIcon,
>   		sortable: true,
>   	    },
>   	    {

-- 
- Lukas





More information about the pve-devel mailing list