[pve-devel] [PATCH installer v2 0/3] tui: remove global, unsafe setup info

Christoph Heiss c.heiss at proxmox.com
Wed Oct 25 10:56:21 CEST 2023

Removes the `static mut` for holding a `SetupInfo` instance.

This is done by either passing the needed info as parameter, or in some
cases, the needed information is already available through other means.

Not only does it get rid of some ugly, unsafe code, it is needed anyway
as a prerequisite by Aaron for pulling out non-TUI-related code into a
separate, shared crate.

No functional changes overall.

v1: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059335.html

Changes v1 -> v2:
  * Rebased on latest master, no actual changes otherwise

Christoph Heiss (3):
  tui: refactor `NetworkOptions` to have a `defaults_from()` function
  tui: bootdisk: pass down product info to advanced dialog
  tui: remove obsolete, global `SetupInfo` state

 proxmox-tui-installer/src/main.rs           | 34 +++-------
 proxmox-tui-installer/src/options.rs        | 75 ++++++++++-----------
 proxmox-tui-installer/src/setup.rs          | 10 ++-
 proxmox-tui-installer/src/views/bootdisk.rs | 74 +++++++++++++-------
 4 files changed, 95 insertions(+), 98 deletions(-)


More information about the pve-devel mailing list