[pve-devel] applied: [PATCH installer v3] fix #4869: Show state in management interface ComboBox

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Oct 19 14:20:46 CEST 2023

Am 19/10/2023 um 10:35 schrieb Maximiliano Sandoval R:
> From: Maximiliano Sandoval <m.sandoval at proxmox.com>
> This is a continuation of
> https://lists.proxmox.com/pipermail/pve-devel/2023-August/058639.html.
> Signed-off-by: Maximiliano Sandoval R <m.sandoval at proxmox.com>
> ---
> v3 was tested only with `make check-pve`. v2 was properly tested by Filip
> Schauer <f.schauer at proxmox.com> in a VM.
> Differences from v2:
>   - Use a escaped utf8 character instead of using `use uft-8;`
> Differences from v1:
>   - Instead of adding a `- UP` or `- DOWN` to the interface label, we display a
>     green BLACK CIRCLE ● similar to what systemd does. To achieve this we
>     separate the GtkWidget in the dropdown in two, and set the color of the new
>     one to green. It was discussed off-list that adding a character for
>     interfaces that were down introduced too much visual noise.
>  proxinstall | 19 +++++++++++++++++--
>  1 file changed, 17 insertions(+), 2 deletions(-)

applied, thanks!

I also added this to the TUI, it's important that we keep feature-parity
for those.

More information about the pve-devel mailing list