[pve-devel] [PATCH proxmox-widget-toolkit v1 2/2] fix #4546: utils: save expiring date of user account for UI

Stefan Sterz s.sterz at proxmox.com
Fri Oct 6 16:41:46 CEST 2023


On Fri Sep 22, 2023 at 4:36 PM CEST, Philipp Hufnagl wrote:

-- snip 8< --

> +$text-color-warning: hsl(48deg, 100%, 50%);
>
>  // Borders
>  $border-color: hsl(0deg, 0%, 40%);
> diff --git a/src/proxmox-dark/scss/extjs/_menu.scss b/src/proxmox-dark/scss/extjs/_menu.scss
> index 2983f60..aa51260 100644
> --- a/src/proxmox-dark/scss/extjs/_menu.scss
> +++ b/src/proxmox-dark/scss/extjs/_menu.scss
> @@ -33,6 +33,10 @@
>    color: $icon-color;
>  }
>
> +.x-menu-item-icon-default.warning {
> +  color: $text-color-warning;
> +}
> +

same here, please don't define new colors unless you must. in this case
there is an argument to be made that this needs to be a new color as we
don't have a text color for warnings.

except, we kind of do: gauges use a brigther version of the warning and
invalid background colors. please factor these out into their own
variables and use those here and in `src/proxmox-dark/scss/_charts.scss`,
which is where we curretnly define the brigther colors.

-- snip 8< --





More information about the pve-devel mailing list