[pve-devel] [PATCH proxmox-widget-toolkit v1 1/2] fix #4546: css: Inform user administrator about user accounts expiring soon

Stefan Sterz s.sterz at proxmox.com
Fri Oct 6 16:41:09 CEST 2023

On Fri Oct 6, 2023 at 3:16 PM CEST, Lukas Wagner wrote:
-- snip 8< --

> > +$background-hint: hsl(233deg, 99%, 60%);
> That particular color tone looks pretty out of place to me in dark mode.
> In light mode, you use the same hue as other interface elements, is
> there a reason why you use a different color in dark mode?
> Playing around a bit, hsl(205, 100%, 40%) or hsl(205, 100%, 45%) would
> look about right for me, that's the same hue as other elements,
> while being a bit toned down (reduced lightness).
> @sterzy, maybe you can provide some feedback as well?
> Also, small bug: the hint-color seems to disappear when the 'expiry'
> is clicked, only seems to affect dark mode.

in general: please refrain from defining new colors. you are very likely
not the first person that needs to highlight something in a row.

in this case: why not use either `$primary-dark` if it needs to be blue.
or in my opinion: use `$background-warning`. this would be semantically
fitting as you want to warn an admin that this user is about to expire.

for the light theme you could simply use the `.warning` class instead
then you can simply overwrite that with a more specific selector in the
dark theme again, like we already do in a couple of places.

defining new colors each time you want to highlight something in the ui
quikly leads to a visual mess, instead try to re-use colors that already
have some kind of semantic meaning. this will make it easier to visually
parse the ui quikly.

-- snip 8< --

More information about the pve-devel mailing list