[pve-devel] [PATCH v2 qemu 1/9] d/rules: use disable-download option instead of git-submodules=ignore

Fiona Ebner f.ebner at proxmox.com
Fri Oct 6 13:01:40 CEST 2023

See the following QEMU commits for reference:
0c5f3dcbb2 ("configure: add --enable-pypi and --disable-pypi")
ac4ccac740 ("configure: rename --enable-pypi to --enable-download, control subprojects too")
6f3ae23b29 ("configure: remove --with-git-submodules=") removed

The last one removed the option and the closest thing to
git-submodule=ignore is using disable-download. Which will then just
verify that the submodules are present.

Building now will require running either
* Running 'meson subprojects download' in the qemu submodule first.
* Using --enable-download, but then the submodules would be downloaded
  for each build (if not already downloaded in the submodule first)
  and it's just a bit too surprising if downloads happen during build.

The disable-download option will also disable automatic downloading of
missing Python modules from PyPI. Hopefully, it's enough to add them
as Debian build dependencies when required.

Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>

No changes in v2.

 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 4d06697..51f56c5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -38,7 +38,7 @@ endif
 	# guest-agent is only required for guest systems
 	./configure \
-	    --with-git-submodules=ignore \
+	    --disable-download \
 	    --docdir=/usr/share/doc/pve-qemu-kvm \
 	    --localstatedir=/var \
 	    --prefix=/usr \

More information about the pve-devel mailing list