[pve-devel] [PATCH installer 0/7] tui: add min/max constraints for bootdisk parameters

Christoph Heiss c.heiss at proxmox.com
Wed Oct 4 16:42:11 CEST 2023

This adds minimum and maximum value constraints to the LVM, Btrfs and
ZFS parameters in the bootdisk dialog. The current behaviour is to to
either silently discard such values, which might yield unexpected
results to users, or to throw some error later on during installation
(due to e.g. failed ZFS pool creation), which does not indicate the
exact cause.

Both cases are really not desirable from a UX standpoint, especially
with e.g. ZFS, where users might not know about the various constraints.

The maximum value is clamped in such a way that the user cannot even
enter a value bigger than allowed (which is the current behavior), but
the same cannot be done for the minimum value. If the allowed range is 9
to 13, one could not enter e.g. `1` first, even if `12` was the desired

Thus, the other approach is to simply validate on the dialog
confirmation, passing down errors. The latter needed some (prep-)work to
convert `Option` -> `Result`. Two new error enums were also introduced,
to better represent errors that occured, rather than fiddeling around
with strings.

The TUI tests introduced in #7 show some techniques how components and
their interactions can be properly tested.

The same can be done for the GUI installer of course, but I didn't want
to include in this series to avoid it being larger-than-necessary.

Christoph Heiss (7):
  tui: fix setting content when using the `DiskSizeEditView` builder
  tui: improve `FormView` error handling
  tui: add optional min-value constraint to `NumericEditView` and
  tui: add min/max constraints for ZFS bootdisk parameters
  tui: add min/max contraints for LVM bootdisk parameters
  tui: add min/max contraints for Btrfs bootdisk parameters
  tui: views: add some TUI component tests

 proxmox-tui-installer/src/main.rs           |  51 ++-
 proxmox-tui-installer/src/options.rs        |   2 +-
 proxmox-tui-installer/src/views/bootdisk.rs | 151 ++++---
 proxmox-tui-installer/src/views/mod.rs      | 421 ++++++++++++++++----
 proxmox-tui-installer/src/views/timezone.rs | 115 +++++-
 5 files changed, 608 insertions(+), 132 deletions(-)


More information about the pve-devel mailing list