[pve-devel] applied-series: [PATCH network 0/7] PUT API endpoint changes

Wolfgang Bumiller w.bumiller at proxmox.com
Wed Nov 22 12:53:43 CET 2023


This is a breaking API change for zones, vnets and subnets!

These previously expected the *complete* config, which is not how our
usual SectionConfigs work.

Further, they advertised a 'delete' API parameter which was simply
passed through as a config property which of course failed validation.

Instead, they now merge the provided changes the way we normally do, and
handle the 'delete' parameter.

This affects:
- /cluster/sdn/zones/<id>
- /cluster/sdn/vnets/<id>
- /cluster/sdn/vnets/<id>/subnets/<subnet>

Additionally, these already took partial updates, but ignored the
'delete' parameter, which is fixed in this series:
- /cluster/sdn/ipams/<id>
- /cluster/sdn/dns/<id>
- /cluster/sdn/controllers/<id>

Wolfgang Bumiller (7):
  Revert "sdn: require ipam in simple plugin for dhcp"
  api: take partial configs for PUT /cluster/sdn/zones/<id>
  api: take partial configs for PUT /cluster/sdn/vnets/<id>
  api: take partial configs for PUT /cluster/sdn/vnets/<n>/subnets/<i>
  api: handle delete parameter when updating ipams
  api: handle delete parameter when updating dns entries
  api: handle delete parameter when updating controllers

 src/PVE/API2/Network/SDN/Controllers.pm   |  7 +++++++
 src/PVE/API2/Network/SDN/Dns.pm           |  7 +++++++
 src/PVE/API2/Network/SDN/Ipams.pm         |  7 +++++++
 src/PVE/API2/Network/SDN/Subnets.pm       | 12 ++++++++++--
 src/PVE/API2/Network/SDN/Vnets.pm         | 24 +++++++++++++++++++----
 src/PVE/API2/Network/SDN/Zones.pm         | 18 ++++++++++++++---
 src/PVE/Network/SDN/Zones/SimplePlugin.pm |  1 -
 7 files changed, 66 insertions(+), 10 deletions(-)

-- 
2.39.2





More information about the pve-devel mailing list