[pve-devel] [PATCH widget-toolkit] notification matcher: fix inverted match modes
Dominik Csapak
d.csapak at proxmox.com
Mon Nov 20 16:05:17 CET 2023
yes, this fixes setting/loading the inverted modes
it seems i have sent a hunk too much with my followup
thanks for fixing!
Reviewed-by: Dominik Csapak <d.csapak at proxmox.com>
Tested-by: Dominik Csapak <d.csapak at proxmox.com>
On 11/20/23 15:53, Fiona Ebner wrote:
> The 'not' prefix is already stripped in the set() method of the view
> model's 'rootMode' and not present anymore when updating the store.
> The information about whether the mode is inverted or not is present
> in the 'invert' data member.
>
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
> src/window/NotificationMatcherEdit.js | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/src/window/NotificationMatcherEdit.js b/src/window/NotificationMatcherEdit.js
> index 5a88288..ee08c16 100644
> --- a/src/window/NotificationMatcherEdit.js
> +++ b/src/window/NotificationMatcherEdit.js
> @@ -778,12 +778,8 @@ Ext.define('Proxmox.panel.NotificationMatchRuleTree', {
> matchCalendarStmts.push(data.value);
> break;
> case 'mode':
> - if (data.value.startsWith('not')) {
> - modeStmt = data.value.substring(3); // after 'not''
> - invertMatchStmt = true;
> - } else {
> - modeStmt = data.value;
> - }
> + modeStmt = data.value;
> + invertMatchStmt = data.invert;
> break;
> }
>
More information about the pve-devel
mailing list