[pve-devel] [PATCH manager 1/2] api: pools: support nested pools

Fabian Grünbichler f.gruenbichler at proxmox.com
Fri Nov 17 16:27:16 CET 2023


> Wolfgang Bumiller <w.bumiller at proxmox.com> hat am 17.11.2023 12:58 CET geschrieben: 
> minor issue

> > diff --git a/PVE/API2/Pool.pm b/PVE/API2/Pool.pm
> > index 51ac71941..54e744558 100644
> > --- a/PVE/API2/Pool.pm
> > +++ b/PVE/API2/Pool.pm
> > @@ -354,6 +476,9 @@ __PACKAGE__->register_method ({
> >  
> >  	    my $pool_config = $usercfg->{pools}->{$pool};
> >  	    die "pool '$pool' does not exist\n" if !$pool_config;
> > +	    for my $subpool (sort keys %{$pool_config->{pools}}) {
> 
> would prefer $pool_config->{pools}->%*

I'll add a follow-up patch that changes the whole sub as clean-up, I used the old style to be internally consist with the loops below ;)





More information about the pve-devel mailing list