[pve-devel] applied: [PATCH installer] tui: fix changing between non-LVM and LVM filesystem in bootdisk chooser

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Nov 17 13:20:31 CET 2023

Am 17/11/2023 um 13:12 schrieb Christoph Heiss:
> Happens due to a force-unwrap() under the false assumption that the
> disk for LVM configurations always exists when switching to a LVM
> filesystem.
> This fails spectacularly with a panic when switching from e.g. Btrfs to
> ext4 in the filesystem chooser.
> Fixes: eda9fa0 ("fix #4856: tui: bootdisk: use correct defaults in advanced dialog")
> Reported-by: Christian Ebner <c.ebner at proxmox.com>
> Signed-off-by: Christoph Heiss <c.heiss at proxmox.com>
> ---
>  proxmox-tui-installer/src/views/bootdisk.rs | 29 +++++++++++----------
>  1 file changed, 15 insertions(+), 14 deletions(-)

applied, thanks!

Could be nice to get the installer code unwrap free in the future, or
at least add a safety comment for each case (but preferably the former)

More information about the pve-devel mailing list