[pve-devel] [PATCH v4 qemu-server 0/4] fix #4957: add vendor and product information passthrough for SCSI-Disks
Hannes Duerr
h.duerr at proxmox.com
Fri Nov 17 12:53:07 CET 2023
changes in v2:
- when calling the API to create/update a VM, check whether the devices
are "scsi-hd" or "scsi-cd" devices,where there is the option to add
vendor and product information, if not error out
- change the format in product_fmt and vendor_fmt to a pattern that only
allows 40 characters consisting of upper and lower case letters, numbers and '-' and '_'.
changes in v3:
- splitup into preparation and fix patch
- move get_scsi_devicetype into QemuServer/Drive.pm
- refactor check_scsi_feature_compatibility to assert_scsi_feature_compatibility
- assert_scsi_feature_compatibility before creating the device
- handle 'local-lvm:' syntax in get_scsi_devicetype
- fix style issues
changes in v4:
- create assert_scsi_feature_compatibility() in API2/Qemu.pm
- divide the preparation into smaller steps
- remove or harden brittle regex
- fix wrong storagename assumption
Hannes Duerr (4):
Move path_is_scsi to QemuServer/Drive.pm
Move NEW_DISK_RE to QemuServer/Drive.pm
drive: Create get_scsi_devicetype
fix #4957: add vendor and product information passthrough for
SCSI-Disks
PVE/API2/Qemu.pm | 49 +++++++++++++++--
PVE/QemuServer.pm | 100 +++++----------------------------
PVE/QemuServer/Drive.pm | 119 ++++++++++++++++++++++++++++++++++++++++
3 files changed, 177 insertions(+), 91 deletions(-)
--
2.39.2
More information about the pve-devel
mailing list