[pve-devel] [PATCH manager v4 0/3] fix 2515 use size defaults

Maximiliano Sandoval m.sandoval at proxmox.com
Fri Nov 17 09:30:55 CET 2023

Tested on a 3-node cluster.

Set `osd_pool_default_min_size` and `osd_pool_default_size` on
ceph.confg to min_size=1 size=2, created a pool using the web UI and it
has the correct size after creation.

One things I noticed is that if you set them to, for example min_size=3,
size=2, no errors will be displayed in the web UI until the creation
fails with:

    Could not set: min_size, size

I am not sure if this should be catched a bit earlier in the web UI, in
the same way we catch size=1 and prevent the creation of the pool. It is
an invalid configuration file after all.

Tested `ceph config set X value`. The values in ceph.conf indeed take
priority as per the commit message. When the values are not present in
ceph.conf, the values from the config DB take preference over the 3/2
default as expected.

Tested-by: Maximiliano Sandoval <m.sandoval at proxmox.com>

Aaron Lauterer <a.lauterer at proxmox.com> writes:

> The main goal of this series is to improve the handling of configured
> default size & min_size values when creating a new Ceph Pool in the GUI.
> A new Ceph API endpoint, 'cfg/value', is added. It allows us to fetch
> values for config keys that are set either in the config DB of Ceph or
> in the ceph.conf file.
> changes since
> v3: rebased
> v2:
> * API rework has been already applied
> * cleaned up JS code to set default values right where we get them from
>   the API instead of at multiple places in the CephPoolInputPanel
>   itself.
> Aaron Lauterer (3):
>   api: ceph: add endpoint to fetch config keys
>   fix #2515: ui: ceph pool create: use configured defaults for size and
>     min_size
>   ui: ceph pool edit: rework with controller and formulas
>  PVE/API2/Ceph/Cfg.pm      |  82 ++++++++++++++++++++++
>  www/manager6/ceph/Pool.js | 144 +++++++++++++++++++++++++++++---------
>  2 files changed, 191 insertions(+), 35 deletions(-)


More information about the pve-devel mailing list