[pve-devel] [PATCH many 00/27] overhaul notification system, use matchers instead of filters

Dominik Csapak d.csapak at proxmox.com
Mon Nov 13 15:34:58 CET 2023

a few high level ui things
(i did not look too deeply in the code, but i'll send
probably some comments there too)

that probably was already there, but i find the all/any + invert combination
confusing (i had to think about it for a bit before getting a grasp on it)

i would propose we can write the four options out what they mean
and internally convert them to all/any + invert, e.g.

'all rule match'
'any rule match'
'at least one rule does not match' (all + invert)
'no rule matches' (any + invert)

(also is the change from and/or to all/any not a breaking change?,
did we expose this in the api yet ?)

second, we already have a very similar interface in the guest wizard for
the disks, and there we have the remove button inline,
i guess we should keep the style consistent

third, do we really need the tree? we basically have the
four options from above, and then a list of the matches

wouldn't it be enough to seperate them?

e.g. have a dropdown with the four options + a list instead of a tree?

also currently the match options are not really verified before
i can submit the form

More information about the pve-devel mailing list