[pve-devel] applied-series: [PATCH v2 pve-manager 0/2] add bulk suspend

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 13 14:25:02 CET 2023


Am 13/11/2023 um 11:20 schrieb Hannes Laimer:
> Adds support for bulk suspending VMs as it already exists for stop.
> 
> v2, thanks @Thomas:
> * api: skip CTs + fix permission checks
> * ui: disable `suspendall` button if user isn;t allowed to use it
> * ui: use new bulk action filtering
> 
> Hannes Laimer (2):
>   api: add suspendall endpoint
>   ui: add bulk suspend support
> 
>  PVE/API2/Nodes.pm                 | 124 ++++++++++++++++++++++++++++++
>  www/manager6/Utils.js             |   1 +
>  www/manager6/node/CmdMenu.js      |  15 ++++
>  www/manager6/node/Config.js       |  14 ++++
>  www/manager6/window/BulkAction.js |   5 +-
>  5 files changed, 157 insertions(+), 2 deletions(-)
> 


applied series, thanks!

I made the "passed VMID of a CT" case use log_warn though, so it's more
visible that something odd was requested.

And UX style wise it could be nicer if we have "fixed" filters for the
store, as currently one can easily hit the "Clear Filters" button and
then can select all CTs (or stopped VMs) without any hint that suspension
for these won't work.

But it's not a biggie and did not want to block on that, so just for the
record that we can probably improve on this.





More information about the pve-devel mailing list